Print labels with their colors on lab label list#888
Print labels with their colors on lab label list#888zampierilucas wants to merge 3 commits intozaquestion:masterfrom
Conversation
This takes the label.color hex and converts it to color in HexToRGB in utils, then uses rgbterm lib to convert rgb to terminal color. Signed-off-by: Lucas Zampieri <lzampier@redhat.com>
zampierilucas
force-pushed
the
label_color
branch
from
51da8c3 to
83be724
Compare
|
This is what the labels look like with the change. |
|
as a go noob , I was not able to run the PR from the folder via |
|
I like this change but I think it should be optional. @zampierilucas I think you should add a config option for this to enable the colors. That way users can set it in their lab.toml and not worry about it. |
Label colored printing can be enabled by the --color param, or by using the config file. Signed-off-by: Lucas Zampieri <lzampier@redhat.com>
|
@prarit I've updated my mr with you suggestion. |
title Signed-off-by: Lucas Zampieri <lzampier@redhat.com>
bmeneg
left a comment
bmeneg
left a comment
There was a problem hiding this comment.
We can make this change generic to every lab command.
Since it's a bigger change, this one is fine wrt the request.
|
was the CI failure linked to this PR ? else maybe it's mergeable ? |
4 participants
This takes the
label.Colorhex and converts it to color in HexToRGB in utils, then uses is to set the background color.Closes: #887