Replace StyleCI with PHP CS Fixer

.github/workflows/rector-cs.yml

@@ -0,0 +1,27 @@
+name: Rector + PHP CS Fixer
+
+on:
+  pull_request_target:
+    paths:
+      - 'src/**'
+      - 'tests/**'
+      - '.github/workflows/rector-cs.yml'
+      - 'composer.json'
+      - 'rector.php'
+      - '.php-cs-fixer.dist.php'
+
+permissions:
+  contents: read
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}
+  cancel-in-progress: true
+
+jobs:
+  rector:
+    uses: yiisoft/actions/.github/workflows/rector-cs.yml@master
+    secrets:
+      token: ${{ secrets.YIISOFT_GITHUB_TOKEN }}
+    with:
+      repository: ${{ github.event.pull_request.head.repo.full_name }}
+      php: '8.0'

.gitignore

@@ -28,3 +28,7 @@ phpunit.phar
 /phpunit.xml
 # phpunit cache
 .phpunit.result.cache
+
+# PHP CS Fixer
+/.php-cs-fixer.cache
+/.php-cs-fixer.php

.php-cs-fixer.dist.php

@@ -0,0 +1,40 @@
+<?php
+
+declare(strict_types=1);
+
+use PhpCsFixer\Config;
+use PhpCsFixer\Finder;
+use PhpCsFixer\Runner\Parallel\ParallelConfigFactory;
+
+$finder = (new Finder())->in([
+    __DIR__ . '/src',
+    __DIR__ . '/tests',
+]);
+
+// TODO: Update the configuration after raising the minimum PHP version
+return (new Config())
+    ->setRiskyAllowed(true)
+    ->setParallelConfig(ParallelConfigFactory::detect())
+    ->setRules([
+        '@PER-CS2.0' => true,
+        'nullable_type_declaration' => true,
+        'operator_linebreak' => true,
+        'ordered_types' => ['null_adjustment' => 'always_last', 'sort_algorithm' => 'none'],
+        'single_class_element_per_statement' => true,
+        'types_spaces' => true,
+        'no_unused_imports' => true,
+        'ordered_class_elements' => true,
+        'class_attributes_separation' => ['elements' => ['method' => 'one']],
+        'declare_strict_types' => true,
+        'native_function_invocation' => true,
+        'native_constant_invocation' => true,
+        'fully_qualified_strict_types' => [
+            'import_symbols' => true
+        ],
+        'global_namespace_import' => [
+            'import_classes' => true,
+            'import_constants' => true,
+            'import_functions' => true,
+        ],
+    ])
+    ->setFinder($finder);

composer.json

@@ -34,6 +34,7 @@
         "symfony/finder": "^5.4|^6.0|^7.1"
     },
     "require-dev": {
+        "friendsofphp/php-cs-fixer": "^3.66",
         "maglnet/composer-require-checker": "^4.2",
         "phpunit/phpunit": "^9.5",
         "rector/rector": "^2.0.3",

src/Classifier.php

@@ -8,6 +8,10 @@
 use ReflectionClass;
 use Symfony\Component\Finder\Finder;
 
+use function count;
+
+use const DIRECTORY_SEPARATOR;
+
 /**
  * Classifier traverses file system to find classes by a certain criteria.
  */
@@ -37,7 +41,7 @@
      */
     public function __construct(string $directory, string ...$directories)
     {
         $this->directories = [$directory, ...array_values($directories)];
     }
 
     /**
@@ -46,8 +50,8 @@
      */
     public function withInterface(string ...$interfaces): self
     {
         $new = clone $this;
         array_push($new->interfaces, ...array_values($interfaces));
 
         return $new;
     }
@@ -58,7 +62,7 @@
      */
     public function withParentClass(string $parentClass): self
     {
         $new = clone $this;
         $new->parentClass = $parentClass;
         return $new;
     }
@@ -69,8 +73,8 @@
      */
     public function withAttribute(string ...$attributes): self
     {
         $new = clone $this;
         array_push($new->attributes, ...array_values($attributes));
 
         return $new;
     }
@@ -108,14 +112,14 @@
 
             $matchedDirs = array_filter(
                 $directories,
-                static fn($directory) => str_starts_with($reflection->getFileName(), $directory)
+                static fn($directory) => str_starts_with($reflection->getFileName(), $directory),
             );
 
             if (count($matchedDirs) === 0) {
                 continue;
             }
 
             if ($countInterfaces > 0) {
                 $interfaces = $reflection->getInterfaces();
                 $interfaces = array_map(static fn(ReflectionClass $class) => $class->getName(), $interfaces);
 
@@ -124,11 +128,11 @@
                 }
             }
 
             if ($countAttributes > 0) {
                 $attributes = $reflection->getAttributes();
                 $attributes = array_map(
                     static fn(ReflectionAttribute $attribute) => $attribute->getName(),
-                    $attributes
+                    $attributes,
                 );
 
                 if (count(array_intersect($this->attributes, $attributes)) !== $countAttributes) {

tests/Support/Attributes/AuthorAttribute.php

@@ -7,6 +7,4 @@
 use Attribute;
 
 #[Attribute]
-class AuthorAttribute
-{
-}
+class AuthorAttribute {}

tests/Support/Author.php

@@ -7,6 +7,4 @@
 use Yiisoft\Classifier\Tests\Support\Attributes\AuthorAttribute;
 
 #[AuthorAttribute]
-class Author
-{
-}
+class Author {}

tests/Support/AuthorPost.php

@@ -8,6 +8,4 @@
 use Yiisoft\Classifier\Tests\Support\Interfaces\PostInterface;
 
 #[AuthorAttribute]
-class AuthorPost implements PostInterface
-{
-}
+class AuthorPost implements PostInterface {}

tests/Support/Dir1/UserInDir1.php

@@ -6,6 +6,4 @@
 
 use Yiisoft\Classifier\Tests\Support\Interfaces\UserInterface;
 
-class UserInDir1 implements UserInterface
-{
-}
+class UserInDir1 implements UserInterface {}

tests/Support/Dir2/UserInDir2.php

@@ -6,6 +6,4 @@
 
 use Yiisoft\Classifier\Tests\Support\Interfaces\UserInterface;
 
-class UserInDir2 implements UserInterface
-{
-}
+class UserInDir2 implements UserInterface {}

tests/Support/Interfaces/PostInterface.php

@@ -4,6 +4,4 @@
 
 namespace Yiisoft\Classifier\Tests\Support\Interfaces;
 
-interface PostInterface
-{
-}
+interface PostInterface {}

tests/Support/Interfaces/UserInterface.php

@@ -4,6 +4,4 @@
 
 namespace Yiisoft\Classifier\Tests\Support\Interfaces;
 
-interface UserInterface
-{
-}
+interface UserInterface {}

tests/Support/Post.php

@@ -6,6 +6,4 @@
 
 use Yiisoft\Classifier\Tests\Support\Interfaces\PostInterface;
 
-class Post implements PostInterface
-{
-}
+class Post implements PostInterface {}

tests/Support/PostUser.php

@@ -7,6 +7,4 @@
 use Yiisoft\Classifier\Tests\Support\Interfaces\PostInterface;
 use Yiisoft\Classifier\Tests\Support\Interfaces\UserInterface;
 
-class PostUser implements UserInterface, PostInterface
-{
-}
+class PostUser implements UserInterface, PostInterface {}

tests/Support/SuperSuperUser.php

@@ -4,6 +4,4 @@
 
 namespace Yiisoft\Classifier\Tests\Support;
 
-class SuperSuperUser extends SuperUser
-{
-}
+class SuperSuperUser extends SuperUser {}

tests/Support/SuperUser.php

@@ -4,6 +4,4 @@
 
 namespace Yiisoft\Classifier\Tests\Support;
 
-class SuperUser extends User implements UserSubInterface
-{
-}
+class SuperUser extends User implements UserSubInterface {}

tests/Support/User.php

@@ -6,6 +6,4 @@
 
 use Yiisoft\Classifier\Tests\Support\Interfaces\UserInterface;
 
-class User implements UserInterface
-{
-}
+class User implements UserInterface {}

tests/Support/UserSubInterface.php

@@ -6,6 +6,4 @@
 
 use Yiisoft\Classifier\Tests\Support\Interfaces\UserInterface;
 
-interface UserSubInterface extends UserInterface
-{
-}
+interface UserSubInterface extends UserInterface {}

tests/Support/UserSubclass.php

@@ -4,6 +4,4 @@
 
 namespace Yiisoft\Classifier\Tests\Support;
 
-class UserSubclass implements UserSubInterface
-{
-}
+class UserSubclass implements UserSubInterface {}