Skip to content

Conversation

@alex268
Copy link
Member

@alex268 alex268 commented Feb 9, 2026

No description provided.

@alex268 alex268 requested a review from pnv1 February 9, 2026 12:32
@codecov-commenter
Copy link

codecov-commenter commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 98.18182% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.77%. Comparing base (4bdd18a) to head (49cf8af).
⚠️ Report is 2 commits behind head on release_v2.4.0.

Files with missing lines Patch % Lines
...ain/java/tech/ydb/table/values/PrimitiveValue.java 98.18% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             release_v2.4.0     #587      +/-   ##
====================================================
+ Coverage             65.73%   65.77%   +0.04%     
- Complexity             2826     2831       +5     
====================================================
  Files                   344      344              
  Lines                 14410    14395      -15     
  Branches               1497     1484      -13     
====================================================
- Hits                   9472     9468       -4     
+ Misses                 4268     4264       -4     
+ Partials                670      663       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the PrimitiveValue.Bytes/Yson implementation to store data as ByteString, revises toString() output to a hex-based format with truncation, and adjusts tests to validate the new behavior.

Changes:

  • Reworked PrimitiveValue byte-backed primitives to use ByteString internally and added a cached byte[] for “unsafe” access.
  • Changed Bytes/Yson toString() from octal-escaped string output to Type[len=... content=...] with truncation.
  • Updated/expanded unit tests for equality, identity semantics of getters, and toString() formatting; made ProtoValueReaderTest bytes fixture encoding deterministic.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

File Description
table/src/main/java/tech/ydb/table/values/PrimitiveValue.java Updates Bytes internal representation, caching, toString(), and related constructors.
table/src/test/java/tech/ydb/table/values/PrimitiveValueTest.java Adjusts tests to new toString() and adds assertions around equals/identity/copy semantics.
table/src/test/java/tech/ydb/table/result/impl/ProtoValueReaderTest.java Makes the bytes test input deterministic (no platform default charset).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alex268 alex268 merged commit 4e71d05 into ydb-platform:release_v2.4.0 Feb 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants