Skip to content

Conversation

@DanilSabirov
Copy link
Contributor

The methods describeTopic, describeConsumer, createTopic, alterTopic, dropTopic have a similar problem of TCP connection growth as commitOffset (#567)

I suggest using the PreferReadyChannel strategy in these methods as well.

@DanilSabirov DanilSabirov force-pushed the master branch 3 times, most recently from 6977d61 to 91b5d9f Compare February 10, 2026 10:57
@alex268
Copy link
Member

alex268 commented Feb 10, 2026

@DanilSabirov, you need also to add support of JDK8 for Mockito like here

…scribeTopic, describeConsumer, createTopic, alterTopic, dropTopic methods
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.48%. Comparing base (5a488c4) to head (fc2f8e9).

Files with missing lines Patch % Lines
...b/topic/settings/TopicClientOperationSettings.java 88.88% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #583      +/-   ##
============================================
+ Coverage     63.04%   63.48%   +0.43%     
- Complexity     2478     2491      +13     
============================================
  Files           333      334       +1     
  Lines         13992    13999       +7     
  Branches       1418     1418              
============================================
+ Hits           8821     8887      +66     
+ Misses         4520     4462      -58     
+ Partials        651      650       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alex268 alex268 merged commit 6e4a682 into ydb-platform:master Feb 11, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants