Support a config field for adding/updating link to source project tree#107
Open
patrasap0908 wants to merge 5 commits intoyahoo:masterfrom
Open
Support a config field for adding/updating link to source project tree#107patrasap0908 wants to merge 5 commits intoyahoo:masterfrom
patrasap0908 wants to merge 5 commits intoyahoo:masterfrom
Conversation
Author
|
@dwighthubbard, let me know if this is what you had in mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for a configuration field that'll cause the
screwdrivercd_versionutility to add/update the link to the current build's source project tree using the associated commit's SHA-1 hash in the package's metadata.Description
Defined a new configuration field named
link_to_projectand leveraged existing functions to read the value of the field from the config file. Generated the link to the associated source project tree using Screwdriver's environment variables,SCM_URLandSD_BUILD_SHA. It setslink_to_project = "${SCM_URL} + '/tree/' + ${SD_BUILD_SHA}"in the package's metadata.Related Issue
#43
Motivation and Context
This feature adds a link to the source project tree to the metadata for every new package version for improved tracking and visibility.
How Has This Been Tested?
Unit tests have been added to
tests/test_versioners.py.Types of changes
Checklist:
License
I confirm that this contribution is made under a Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.