Please add to npmjs.org repository#1
Open
doedje wants to merge 5 commits intoxtreemrage:masterfrom
doedje:master
Open
Please add to npmjs.org repository#1doedje wants to merge 5 commits intoxtreemrage:masterfrom doedje:master
doedje wants to merge 5 commits intoxtreemrage:masterfrom
doedje:master
Conversation
This way it can also be published to npmjs.org and I can add it as a dependency for jquery.soap there too. (this in response to a issue about the dependency missing in bower.....)
as requested by the good people at the plugin.jquery.com website....
Also a little change to your readme: at least the example is now illustrating the usage of jquery.xml2json... =]
current setting is blocking usage of jquery.xml2json with versions 1.9, 1.10 and 2.x of jquery...
Author
|
Any change you merge this pull request? I just changed the jquery dependency to >=1.9 for bower so it is usable with more jquery versions, especially the 2.x versions..... would be nice! =) |
|
Hi ! This will be greate if you can merge this pull request ! Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi XTREEMRAGE,
I added a package.json file so it could also be published to the npmjs.org repository. Would you mind doing that? (I did not validate the package.json by the way...) If you would like to do that I can mention jquery.xml2json as a dependency for jquery.soap on that repo as well. Like I also did for the one on bower.
Thanx! And thank you for mentioning jquery.soap in your readme!! =]