Skip to content

Fix macOS framework builds#439

Open
antonc27 wants to merge 1 commit intoxiph:mainfrom
antonc27:patch-1
Open

Fix macOS framework builds#439
antonc27 wants to merge 1 commit intoxiph:mainfrom
antonc27:patch-1

Conversation

@antonc27
Copy link

This PR fixes 2 issues with CI builds of macOS framework:

  1. Correct flag should be OPUS_BUILD_FRAMEWORK, not BUILD_FRAMEWORK.
  2. Correct CMAKE_OSX_ARCHITECTURES should be set, otherwise host arch will be used.

P.S.

2 more thoughts:

  1. I haven't checked myself, but iOS framework should also use OPUS_BUILD_FRAMEWORK, not BUILD_FRAMEWORK
  2. FRAMEWORK_VERSION in cmake list should be probably set to "A" (major verison), not ${PROJECT_VERSION}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments