fix(packages): Remove unnecessary code and add types for untyped code and prettify everything #2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
PatrykKuniczak
force-pushed
the
fix/remove-unnecessary-code-and-add-missing-types
branch
2 times, most recently
from
6ab2337 to
f3ccc32
Compare
…unction of generate.ts
…o newer equivalent
…ocs for getMetas() and setMetas()
…send(), for avoid unnecessary code run
…hange, avoids @ts-expect-error for tests
…ix `Unresolved variable or type HtmlPublicPath` error
…x possibly undefined document.head of wxtPluginLoader.ts
…tatement and change deprecated `exists` to `pathExists`
…CASE like real const and remove unnecessary `exists` func and use `pathExists` instead
… `await` and add question
…ssary `await`, make closeBrowser function of ExtensionRunner optional
…remove unnecessary `await`
PatrykKuniczak
force-pushed
the
fix/remove-unnecessary-code-and-add-missing-types
branch
from
f1070ec to
ff88495
Compare
PatrykKuniczak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
anyand@ts-expect-errorand@ts-ignoreawait, beforereturnI'm also added some questions to maintainers under
TODO:keys (let's response, please 😄)PS: I can make it a little better, by configure more restrictions for
eslintandprettier(e.g brackets near to ifs, func and etc.) in other PR and reduce amount of tests, because IMO some of those isn't necessary(e.g this which TS preventing by itself) and we can remove it.Tell me if you overall, interested for more my influence on this project 👀
Manual Testing
Run tests and
pnpm testandpnpm devand check if everything's alright :)