-
Notifications
You must be signed in to change notification settings - Fork 28
Closes #1001 Hide our plugins section for given partners #1002
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
|
@remyperona Thanks for the PR. Please find exploratory test notes below.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements functionality to hide the "Our Plugins" section in the settings page for specific partners. When users sign up through partner ID 18 (Extendify), the plugin family section will not be displayed to them.
Key changes:
- Adds a new function to save partner IDs that require hiding the plugins section
- Integrates this function into both API key setup and user creation flows
- Conditionally renders the "Our Plugins" section based on stored partner information
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| inc/functions/partners.php | Adds new function imagify_save_partner_hide_our_plugins() to store partner IDs that should hide the plugins section |
| inc/common/partners.php | Integrates partner hiding logic when API key is first added |
| inc/classes/class-imagify.php | Integrates partner hiding logic during user creation |
| inc/classes/class-imagify-views.php | Retrieves the stored partner option to pass to the settings template |
| views/page-settings.php | Conditionally renders the "Our Plugins" section based on partner setting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nicomollet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feedback;:
- CI (coverage) not passing
- Partner ID or slug usage?
- We need
What was testedandHow to testplease 🙏
Description
Fixes #1001
Type of change
Detailed scenario
What was tested
imagify_partner_hide_our_pluginsis setHow to test
There is 2 ways to test the flow:
imagifyp_idsetor
imagifyp_idsetIn both of those cases, if the partner ID is
extendify, the Our Plugins section on the settings page should be hidden.This is done through an option called
imagify_partner_hide_our_pluginswhich is saved when deleting the partner ID option after one of the 2 above flow happened, if the partner corresponds to extendify (for now).Affected Features & Quality Assurance Scope
Technical description
Documentation
This PR implements functionality to hide the "Our Plugins" section in the settings page for specific partners. When users sign up through partner, the plugin family section will not be displayed to them.
Key changes:
Mandatory Checklist
Code validation
Code style
Unticked items justification
TBD