Skip to content

PHPStan level 9 #6096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swissspidy merged 38 commits into from
Jul 3, 2025
Merged

PHPStan level 9 #6096

swissspidy merged 38 commits into from
Jul 3, 2025

Conversation

@swissspidy
Copy link
Member

@swissspidy swissspidy commented May 16, 2025 •
edited
Loading

@swissspidy swissspidy requested a review from a team as a code owner May 16, 2025 11:23
@codecov
Copy link

codecov bot commented May 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 74.45255% with 70 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
php/utils.php 71.69% 15 Missing ⚠️
php/WP_CLI/Runner.php 75.86% 14 Missing ⚠️
php/commands/src/CLI_Command.php 33.33% 8 Missing ⚠️
php/class-wp-cli.php 76.00% 6 Missing ⚠️
php/utils-wp.php 50.00% 5 Missing ⚠️
php/WP_CLI/Bootstrap/DefineProtectedCommands.php 0.00% 2 Missing ⚠️
php/WP_CLI/Configurator.php 33.33% 2 Missing ⚠️
php/WP_CLI/Extractor.php 33.33% 2 Missing ⚠️
php/WP_CLI/FileCache.php 66.66% 2 Missing ⚠️
php/WP_CLI/Inflector.php 50.00% 2 Missing ⚠️
... and 10 more

📢 Thoughts on this report? Let us know!

swissspidy
swissspidy commented May 16, 2025
View reviewed changes
@swissspidy swissspidy changed the title PHPStan level 8 PHPStan level 9 May 17, 2025
Base automatically changed from add/bump-requirements to main May 17, 2025 16:40
@swissspidy swissspidy mentioned this pull request Jun 11, 2025
Merged
swissspidy
swissspidy commented Jun 12, 2025
View reviewed changes
@swissspidy
Copy link
Member Author

swissspidy commented Jun 18, 2025

@wp-cli/committers with tests passing, this is now ready for review. Apologies for the large PR :-)

Merging this and later wp-cli/wp-cli-tests#262 will help unblock further type improvements in the respective commands.

lipemat
lipemat reviewed Jun 21, 2025
View reviewed changes
@lipemat lipemat mentioned this pull request Jun 21, 2025
Merged
@swissspidy @lipemat
Apply suggestion from code review
444b150 
Co-authored-by: Mat Lipe <mat@matlipe.com>
@szepeviktor
Copy link
Contributor

szepeviktor commented Jun 21, 2025

What are cooking here in your secret kitchen, Pascal?

@swissspidy
Copy link
Member Author

swissspidy commented Jun 21, 2025

Dang, I thought I could keep this a secret 😃

@swissspidy swissspidy mentioned this pull request Jul 1, 2025
Merged
@swissspidy swissspidy mentioned this pull request Jul 1, 2025
Merged
@swissspidy swissspidy merged commit cbb6a51 into main Jul 3, 2025
51 checks passed
@swissspidy swissspidy deleted the try/phpstan branch July 3, 2025 12:07
@swissspidy swissspidy mentioned this pull request Jul 23, 2025
Merged
@menno-ll menno-ll mentioned this pull request Nov 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ernilambar ernilambar ernilambar approved these changes

+1 more reviewer

@lipemat lipemat lipemat left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug scope:testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@swissspidy @szepeviktor @lipemat @ernilambar