Skip to content

Fix ambiguity by improving regex #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schlessera merged 1 commit into from
Dec 10, 2025
Merged

Fix ambiguity by improving regex #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions features/behat-steps.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,15 @@ Feature: Test that WP-CLI Behat steps work as expected
Then STDOUT should not be empty
And the return code should be 0

@require-wp
Scenario: Test WP installation steps
Given a WP 6.8 installation
When I run `wp core version`
Then STDOUT should contain:
"""
6.8
"""

@require-wp
Scenario: Test WP files and wp-config.php steps
Given an empty directory
Expand All @@ -296,8 +305,6 @@ Feature: Test that WP-CLI Behat steps work as expected
Then STDOUT should not be empty
And the return code should be 0



@require-wp
Scenario: Test version string comparison
Given a WP installation
Expand Down Expand Up @@ -374,6 +381,12 @@ Feature: Test that WP-CLI Behat steps work as expected
WP_CONTENT_DIR
"""

@require-wp
Scenario: Test WP multisite installation
Given a WP multisite installation
When I run `wp core is-installed`
Then the return code should be 0

@require-wp
Scenario: Test WP multisite subdirectory installation
Given a WP multisite subdirectory installation
Expand Down
2 changes: 1 addition & 1 deletion src/Context/GivenStepDefinitions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ public function given_a_database(): void {
*
* @access public
*
* @Given /^a WP( [^\s]+)? install(?:ation)?$/
* @Given /^a WP( \d[^\s]+)? install(?:ation)?$/
*
* @param string $version Optional version number (may include leading space)
*/
Expand Down