Feature: New Stats #24677

kean · 2025-07-18T20:04:29Z

This PR implements the new "Traffic" tab for "Jetpack Stats".

The changes are isolated to the new JetpackStats module, which should make it easier to review – the new code in the module has no risk of introducing regressions to the existing codebase. I limited the number of changes to the existing code – I suggest to focus on that.

In terms of the new architecture and features, I'd suggest asking Claude Code to explain it.

Testing Instructions

Enable New Stats: Open Stats and verify that the tip "Try New Stats" is shown and "Enable Now" buttons works. IT is shown only once.
Test the new features (as you see fit)
Verify that there are no regression in the existing Stats
Verify that you can switch back and forth between new and old stats.

Tip: you can use these options at the bottom to re-test the TipKit:

PRs

This PR (introduces JetpackStats and the initial code from the prototype)
Add PostStatsView #24681
Add Archive top list #24685
Add AuthorStatsView #24686
Add ReferrerStatsView #24687
Add CountriesMapView #24688
Add TopListScreenView #24689
New Stats: Bugfix #24690
New Stats: Customization #24692
New Stats: Misc #24693
New Stats: Integration #24694
New Stats: iPad #24701
New Stats: Analytics #24702
New Stats: Accessibility #24703

Dependency: wordpress-mobile/WordPressKit-iOS#843

Screenshots

dangermattic · 2025-07-18T20:05:15Z

	2 Warnings
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	This PR is assigned to the milestone 26.1. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

wpmobilebot · 2025-07-21T20:25:18Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	`28433`
	Version	`PR #24677`
	Bundle ID	`org.wordpress.alpha`
	Commit	`5b51ea1`
	Installation URL	0p6uqst2l53a0

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2025-07-21T20:25:25Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	`28433`
	Version	`PR #24677`
	Bundle ID	`com.jetpack.alpha`
	Commit	`5b51ea1`
	Installation URL	1518dpjromgag

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

crazytonyli · 2025-08-01T03:15:38Z

I didn't make the connection between the "Site Time Zone" wording and the "Greenwich Mean Time" wording on screen. Instead of saying "Stats are reported and shown in your site's time zone", maybe we can put the time zone in the wording: "Stats are reported and shown in your site's time zone: Greenwich Mean Time."?

crazytonyli · 2025-08-01T03:19:45Z

The card customization seems to be stored app-wide, shared by all sites. What do you think of storing the customization per site? Users may want to see different cards on different sites.

crazytonyli · 2025-08-01T03:35:28Z

The "Most Downloaded" card on my atomic site says "File Download stats are not available for Jetpack sites". I'm not sure what exactly that means. Is it a paid feature? How can I test it?

kean · 2025-08-01T12:02:20Z

Meanwhile, do you mind breaking down this PR into some small ones?

That is not happening, I'm sorry ☺️

app quality team can test

They don't test, but we plan to do a Call for Testing to get more help testing it.

easily lead to duplicated content on the screen

I'm not sure that's a problem – you just don't do that, and you can easily remove a chart you don't need.

The top list's content can not be changed. i.e. "Most viewed pages"

I've also been thinking about it. I think it might be a good idea to fix the first chart, but I'm not sure about "Pages". If you truly don't need it – you'll remove it. Most users will likely never touch customization in the first place.

I'll disable removal of the top chart. I think we want to retain some control over it but let the rest of it be fully editable.

maybe we can put the time zone in the wording: "Stats are reported and shown in your site's time zone: Greenwich Mean Time."?

That's where the "Info" button comes in – you can tap it an it explains it in detail. I didn't want it to take more space than that. It's already an improvement over the web that doesn't have any notes about the reporting timezone.

What do you think of storing the customization per site?

I have this on a list for phase 2, but I'm not sure it's worth complicating it. Most users will likely not even touch customization. Most users have a few sites. I don't think it's worth adding. It will complicate it because some users will want app-wide customization and some won't, and the UI will have to accommodate both, which is too complex.

Is it a paid feature? How can I test it?

I opened a defect: CMM-640. If you find more defects, please report them on Linear so they could be addressed later. It's an experimental feature, and it will ship with defects unless we have show-stoppers.

crazytonyli · 2025-08-04T00:35:25Z

maybe we can put the time zone in the wording: "Stats are reported and shown in your site's time zone: Greenwich Mean Time."?

That's where the "Info" button comes in – you can tap it an it explains it in detail.

I meant updating the wording in the pop-up, not the time zone text at the bottom of the screen.

kean · 2025-08-04T16:47:05Z

I opened a defect: CMM-640.

I fixed time zone conversion in 5231fa9.

kean · 2025-08-04T16:59:00Z

I meant updating the wording in the pop-up, not the time zone text at the bottom of the screen.

Ah, I misunderstood it. Good point. I move the time zone right under "Site Time Zone". Now it should be clear.

This reverts commit 33ce879.

crazytonyli · 2025-08-04T23:38:23Z

WordPress/Classes/ViewRelated/Stats/StatsHostingViewController.swift

+        if additionalSafeAreaInsets.bottom != bottomInset {
+            additionalSafeAreaInsets = UIEdgeInsets(top: 0, left: 0, bottom: min(20, bottomInset), right: 0)
+        }
+    }


This looks a lot like AutoLayout. Can you implement this using constraints?

I plan to eliminate StatsHostingViewController in the scope of https://linear.app/a8c/issue/CMM-631/ipad-show-tabs-in-a-navigation-bar in phase two. The problem and the reason it was needed is that current StatsViewController(legacy) uses UIPageController for switching between pages, which is a bad idea because it's not designed to be used with vertically scrollable content. I plan to refactor it all for the final release.

crazytonyli · 2025-08-04T23:45:03Z

WordPress/Classes/ViewRelated/Stats/SiteStatsDashboardViewController.swift

+
+        if FeatureFlag.newStats.enabled {
+            // Main actions
+            var mainActions: [UIMenuElement] = []


Nitpick: this variable is redundant.

It seems to be used below: menuElements.append(contentsOf: mainActions)

Sorry, I was not clear. By "redundant", I meant that you can put the actions into menuElements directly, without introducing this temporary veriable.

Ah, well this class will be removed in 26.2 anyway.

crazytonyli · 2025-08-04T23:46:21Z

WordPress/Classes/ViewRelated/Stats/Traffic/StatsTrafficDatePickerView.swift

@@ -90,6 +90,8 @@ struct StatsTrafficDatePickerView: View {
 private extension StatsPeriodUnit {
    var label: String {
        switch self {
+        case .hour:
+            fatalError("unsupported")


There are a few of these fatal errors. Replace them with wpAssertionFailure?

Good catch. I forgot to do it. Updated in 1fff562. I used the same returns values as for .day as placeholders.

crazytonyli · 2025-08-06T04:16:11Z

You may want to add JetpackStatsTests to the unit tests test plan, so that it runs on CI.

sonarqubecloud · 2025-08-06T19:55:41Z

Quality Gate passed

Issues
257 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.7% Duplication on New Code

See analysis details on SonarQube Cloud

crazytonyli

Approving to unblock. I have posted comments in the individual PRs listed in #24712.

GitHub is having trouble loading the diff, so I can't comment in the place of the code.

How the card customization is stored in StatsViewModel can be difficult to maintain. It saves TrafficCardConfiguration's default Codable implementation as JSON.

TrafficCardConfiguration has nested properties that are declared and used in other places, whose type declaration may change in the future. If they are changed, the serialization and deserialization may break, which leads to data loss where the display cards go from customized cards to the default ones.

kean added this to the 26.1 milestone Jul 18, 2025

kean added the Stats label Jul 18, 2025

kean force-pushed the feature/jetpack-stats branch from 38a433d to b743e7c Compare July 18, 2025 20:07

kean added 24 commits July 26, 2025 10:12

Update chart to take more horizontal space

b961740

Improve more menu alignment

12a5265

More breezing room

dd8575e

Show top 5

3a193fe

Simplify TopListItemView requirements

6b4ca65

Add previews for top list items

c7cfdbe

Add cache for mock data

5269b0c

Simplify mock data generation

a09bb44

Set min height for bars

7965ebc

Add initial implementation

761bea5

Rework await Task.detached(priority: .userInitiated) {

75c9540

Add zoom

dc9e83f

Refactor

60233d3

Fix reloading in dark mode

5448589

Improve colors

25f1740

Add initial hover support

3c8057a

Extract interactive-map-template

9e523c4

Improve tooltip view

b6c08dd

Refactor

e7a34c9

Clear map selection when you stop hovering

2045459

lintfix

e1e2a20

Add TopListCard previews

b9c3a7e

Improve TopListLocationRowView design

c365399

Cleanup isNavigationDisabled

c4c4982

kean added 3 commits August 1, 2025 15:12

Selection tooltip no longer moves with content

03f1736

Remove delay when showing details

5984fdc

Use black for tint

b823743

kean added 2 commits August 4, 2025 07:10

Update articles

b6613f4

Fix 642: invalid hourly data

5231fa9

Update time zone design

942972c

kean enabled auto-merge August 4, 2025 21:55

kean added 2 commits August 4, 2025 19:06

Update WordPressKit to point to the latest commit

9166c2c

Revert "Fix minimum size for subscriber rows"

7c0e716

This reverts commit 33ce879.

crazytonyli reviewed Aug 4, 2025

View reviewed changes

kean added 2 commits August 5, 2025 09:47

Replace fatalError with assertionFailure

1fff562

Merge branch 'trunk' into feature/jetpack-stats

031a359

kean mentioned this pull request Aug 5, 2025

Stats Review: Integrate JetpackStats in the app (P14) #24726

Closed

Merge branch 'trunk' into feature/jetpack-stats

5b51ea1

crazytonyli approved these changes Aug 6, 2025

View reviewed changes

kean added this pull request to the merge queue Aug 6, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 6, 2025

crazytonyli added this pull request to the merge queue Aug 7, 2025

Merged via the queue into trunk with commit 8601ae5 Aug 7, 2025
30 of 32 checks passed

crazytonyli deleted the feature/jetpack-stats branch August 7, 2025 02:21

Feature: New Stats #24677

Feature: New Stats #24677

Uh oh!

Conversation

kean commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing Instructions

PRs

Screenshots

Uh oh!

dangermattic commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crazytonyli commented Aug 1, 2025

Uh oh!

crazytonyli commented Aug 1, 2025

Uh oh!

crazytonyli commented Aug 1, 2025

Uh oh!

kean commented Aug 1, 2025

Uh oh!

crazytonyli commented Aug 4, 2025

Uh oh!

kean commented Aug 4, 2025

Uh oh!

kean commented Aug 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

crazytonyli commented Aug 6, 2025

Uh oh!

sonarqubecloud bot commented Aug 6, 2025

Quality Gate passed

Uh oh!

crazytonyli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

kean commented Jul 18, 2025 •

edited

Loading

dangermattic commented Jul 18, 2025 •

edited

Loading

wpmobilebot commented Jul 21, 2025 •

edited

Loading

wpmobilebot commented Jul 21, 2025 •

edited

Loading