Skip to content

CMM-1037: Update Stats empty/disabled view UI #22530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nbradbury merged 6 commits into from
Jan 27, 2026
Merged

CMM-1037: Update Stats empty/disabled view UI #22530

nbradbury merged 6 commits into from
Jan 27, 2026
+18 −223

Conversation

@nbradbury
Copy link
Contributor

@nbradbury nbradbury commented Jan 26, 2026 •
edited
Loading

Description

  • Updated stats disabled view layout by removing the illustration image
  • Removed unused drawable resources (img_illustration_stats_226dp.xml)

Testing instructions

Navigate to the (old) Stats and verify the image no longer appears.

Before & after

before

@dangermattic
Copy link
Collaborator

dangermattic commented Jan 26, 2026 •
edited
Loading

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@nbradbury nbradbury added the Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging label Jan 26, 2026
@nbradbury
Copy link
Contributor Author

nbradbury commented Jan 26, 2026

@claude Ignore the TODO in StatsViewModel

@claude

This comment was marked as outdated.

Sign in to view
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 26, 2026 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
FlavorJalapeno
Build TypeDebug
Versionpr22530-bc9ac99
Commitbc9ac99
Direct Downloadwordpress-prototype-build-pr22530-bc9ac99.apk
 Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jan 26, 2026 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
FlavorJalapeno
Build TypeDebug
Versionpr22530-bc9ac99
Commitbc9ac99
Direct Downloadjetpack-prototype-build-pr22530-bc9ac99.apk
 Note: Google Login is not supported on these builds.

@nbradbury nbradbury marked this pull request as ready for review January 27, 2026 12:49
@nbradbury nbradbury requested a review from adalpari January 27, 2026 12:50
adalpari
adalpari approved these changes Jan 27, 2026
View reviewed changes
Copy link
Contributor

@adalpari adalpari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nbradbury nbradbury added Stats Tech Debt and removed Do Not Merge In PRs with this label, our automation will fail a require check, preventing accidental merging labels Jan 27, 2026
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 27, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nbradbury nbradbury enabled auto-merge (squash) January 27, 2026 17:25
@nbradbury nbradbury merged commit d5c5ffc into trunk Jan 27, 2026
23 of 26 checks passed
@nbradbury nbradbury deleted the issue/CMM-1037-statsDisabledView-empty-view branch January 27, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adalpari adalpari adalpari approved these changes

Assignees

No one assigned

Labels

Stats Tech Debt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nbradbury @dangermattic @wpmobilebot @adalpari