Skip to content

Comments

Fix macro protection in SP code for RSA_LOW_MEM#9790

Merged
SparkiDev merged 2 commits intowolfSSL:masterfrom
bigbrett:sp-rsa-unused-var
Feb 18, 2026
Merged

Fix macro protection in SP code for RSA_LOW_MEM#9790
SparkiDev merged 2 commits intowolfSSL:masterfrom
bigbrett:sp-rsa-unused-var

Conversation

@bigbrett
Copy link
Contributor

@bigbrett bigbrett commented Feb 17, 2026

Fixes macro protection for sp_*_cond_add_* in the ARM SP asm code to prevent unused function warning when used with RSA_LOW_MEM.

Before this PR, using RSA_LOW_MEM with WOLFSSL_SP_CORTEX_M_ASM would result in the following compiler warning:

wolfssl/wolfcrypt/src/sp_cortexm.c:29848:39: warning: 'sp_4096_cond_add_64' defined but not used [-Wunused-function]
29848 | WC_OMIT_FRAME_POINTER static sp_digit sp_4096_cond_add_64(sp_digit* r_p,

Generated from https://github.com/wolfSSL/scripts/pull/549

@bigbrett bigbrett self-assigned this Feb 17, 2026
@bigbrett bigbrett marked this pull request as ready for review February 18, 2026 00:00
@bigbrett bigbrett assigned SparkiDev and unassigned bigbrett Feb 18, 2026
@bigbrett
Copy link
Contributor Author

Zephyr test is being flaky

@SparkiDev SparkiDev merged commit 63b9d13 into wolfSSL:master Feb 18, 2026
441 of 444 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants