Skip to content

Conversation

@arjita-mitra
Copy link
Contributor

@arjita-mitra arjita-mitra commented Jan 22, 2026

EpicWPB-20658 Secure & Time-limited Public Links

Pull Request

Summary

  • refactor usepubliclink hook to remove duplication for cells and conversation view
  • test centralised

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

❌ Patch coverage is 46.66667% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.49%. Comparing base (8f99017) to head (c75a431).

Files with missing lines Patch % Lines
...ells/common/useCellPublicLink/useCellPublicLink.ts 70.58% 2 Missing and 3 partials ⚠️
...llsNodeShareModal/useCellConversationPublicLink.ts 16.66% 5 Missing ⚠️
...Columns/CellsShareModal/useCellGlobalPublicLink.ts 20.00% 4 Missing ⚠️
...lsTableColumns/CellsShareModal/CellsShareModal.tsx 0.00% 1 Missing ⚠️
...olumns/CellsNodeShareModal/CellsNodeShareModal.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #20176      +/-   ##
==========================================
- Coverage   45.53%   45.49%   -0.04%     
==========================================
  Files        1632     1633       +1     
  Lines       40337    40266      -71     
  Branches     8334     8320      -14     
==========================================
- Hits        18366    18319      -47     
+ Misses      20040    20019      -21     
+ Partials     1931     1928       -3     
Flag Coverage Δ
app_webapp 43.71% <46.66%> (-0.05%) ⬇️
lib_api_client 50.27% <ø> (ø)
lib_core 58.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...lsTableColumns/CellsShareModal/CellsShareModal.tsx 3.94% <0.00%> (ø)
...olumns/CellsNodeShareModal/CellsNodeShareModal.tsx 3.89% <0.00%> (ø)
...Columns/CellsShareModal/useCellGlobalPublicLink.ts 20.00% <20.00%> (ø)
...ells/common/useCellPublicLink/useCellPublicLink.ts 82.47% <70.58%> (ø)
...llsNodeShareModal/useCellConversationPublicLink.ts 16.66% <16.66%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 113
  • Failed: 3
  • Skipped: 12
  • 🔁 Flaky: 4
  • 📊 Total: 132
  • Total Runtime: 398.4s (~ 6 min 38 sec)
specs/AccountSettingsSpecs/accountSettings.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ account settings > I should not be able to change email of user managed by SCIM (tags: TC-60, regression)
specs/AppLock/AppLock.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ AppLock > Web: App should not lock if I switch back to webapp tab in time (during inactivity timeout) (tags: TC-2752, TC-2753, regression)
specs/ArchiveSpecs/archive.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Accessibility > I want to archive the 1on1 conversation from conversation details (tags: TC-105, regression)
specs/Authentication/authentication.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Authentication > Make sure user does not see data of user of previous sessions on same browser (tags: TC-1311, regression)
specs/Block/block.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Block: User A and User B are NOT in the same team > Verify you can unblock someone from conversation list options (tags: TC-148, regression)
specs/Edit/edit.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Edit > I can see the changed message was edited from another user (tags: TC-692, regression)
specs/SelfDeletingMessages/selfDeletingMessages.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ set globally in group conversation > I want to see a system message that a global timer was set or changed or removed in conversation options (tags: TC-3720, regression)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants