Skip to content

Conversation

@iskvortsov
Copy link
Contributor

@iskvortsov iskvortsov commented Jan 22, 2026

TaskWPB-21646 [Web] Search files in Conversation

Pull Request

Summary

  • Added e2e test for searching files in the conversation
  • Updated README.md for e2e tests

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds an end-to-end test for searching files in group conversations within the Cells feature. The test verifies that users can upload files (images and videos) to a group conversation and search for them using the Files tab search functionality.

Changes:

  • Added new e2e test searchFilesInGroupConversation-TC-8788.spec.ts that tests file upload and search in Cells group conversations
  • Extended page objects with methods for file search operations and video visibility checks
  • Exported VideoFileName constant for reuse across tests
  • Updated README documentation to use correct Nx commands

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
apps/webapp/test/e2e_tests/utils/asset.util.ts Exported VideoFileName constant to make it available for test usage
apps/webapp/test/e2e_tests/specs/CriticalFlow/Cells/searchFilesInGroupConversation-TC-8788.spec.ts New e2e test that verifies file search functionality in Cells group conversations
apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversationFiles.page.ts Added methods for file search, visibility check, and counting files
apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversation.page.ts Updated image locator and added video visibility check method
apps/webapp/test/e2e_tests/README.md Updated documentation with correct Nx command paths

@codecov
Copy link

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.53%. Comparing base (c0be91d) to head (79237c9).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #20173   +/-   ##
=======================================
  Coverage   45.53%   45.53%           
=======================================
  Files        1632     1632           
  Lines       40337    40337           
  Branches     8334     8334           
=======================================
  Hits        18366    18366           
  Misses      20040    20040           
  Partials     1931     1931           
Flag Coverage Δ
app_webapp 43.75% <ø> (ø)
lib_api_client 50.27% <ø> (ø)
lib_core 58.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

iskvortsov and others added 2 commits January 22, 2026 11:47
…rsation.page.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 22, 2026 10:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

iskvortsov and others added 2 commits January 22, 2026 17:05
…rsation.page.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 22, 2026 16:09
…rsation.page.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

…sInGroupConversation-TC-8788.spec.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 22, 2026 16:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 110
  • Failed: 5
  • Skipped: 12
  • 🔁 Flaky: 6
  • 📊 Total: 133
  • Total Runtime: 285.9s (~ 4 min 46 sec)
specs/AccountSettingsSpecs/accountSettings.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ account settings > I should not be able to change email of user managed by SCIM (tags: TC-60, regression)
specs/AppLock/AppLock.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ AppLock > Web: App should not lock if I switch back to webapp tab in time (during inactivity timeout) (tags: TC-2752, TC-2753, regression)
specs/ArchiveSpecs/archive.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Accessibility > I want to archive the 1on1 conversation from conversation details (tags: TC-105, regression)
specs/Authentication/authentication.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Authentication > Verify current browser is set as temporary device (tags: TC-3460, regression)
specs/Block/block.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Block: User A and User B are NOT in the same team > Verify you can unblock someone from conversation list options (tags: TC-148, regression)
specs/ClearConversationContent/clearConversationContent.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Clear Conversation Content > I want to see incoming picture, ping and call after I clear content of a 1:1 conversation via conversation list (tags: TC-8779, regression)
specs/CriticalFlow/Cells/searchFilesInGroupConversation-TC-8788.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Searching files in a group conversation (tags: crit-flow-cells, regression, TC-8788)
specs/CriticalFlow/Cells/uploadingFileInGroupConversation.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Uploading an file in a group conversation (tags: crit-flow-cells, regression)
specs/Edit/edit.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Edit > I cannot edit another users message (tags: TC-683, regression)
specs/Reply/reply.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Reply > I should not be able to send a reply after I got removed from the conversation (tags: TC-3014, regression)
specs/SelfDeletingMessages/selfDeletingMessages.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Self Deleting Messages > Verify sending ephemeral text message in group (tags: TC-658, regression)

…sInGroupConversation-TC-8788.spec.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 22, 2026 16:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

…sInGroupConversation-TC-8788.spec.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 23, 2026 08:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

…sInGroupConversation-TC-8788.spec.ts

Co-authored-by: Mark Brockhoff <95471369+markbrockhoff@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 23, 2026 10:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Copilot AI review requested due to automatic review settings January 23, 2026 14:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants