-
Notifications
You must be signed in to change notification settings - Fork 297
chore(e2e): Added e2e test for searching files in the conversation [WPB-21646] #20173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…rsationFiles.page.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds an end-to-end test for searching files in group conversations within the Cells feature. The test verifies that users can upload files (images and videos) to a group conversation and search for them using the Files tab search functionality.
Changes:
- Added new e2e test
searchFilesInGroupConversation-TC-8788.spec.tsthat tests file upload and search in Cells group conversations - Extended page objects with methods for file search operations and video visibility checks
- Exported
VideoFileNameconstant for reuse across tests - Updated README documentation to use correct Nx commands
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
apps/webapp/test/e2e_tests/utils/asset.util.ts |
Exported VideoFileName constant to make it available for test usage |
apps/webapp/test/e2e_tests/specs/CriticalFlow/Cells/searchFilesInGroupConversation-TC-8788.spec.ts |
New e2e test that verifies file search functionality in Cells group conversations |
apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversationFiles.page.ts |
Added methods for file search, visibility check, and counting files |
apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversation.page.ts |
Updated image locator and added video visibility check method |
apps/webapp/test/e2e_tests/README.md |
Updated documentation with correct Nx command paths |
...ebapp/test/e2e_tests/specs/CriticalFlow/Cells/searchFilesInGroupConversation-TC-8788.spec.ts
Outdated
Show resolved
Hide resolved
...ebapp/test/e2e_tests/specs/CriticalFlow/Cells/searchFilesInGroupConversation-TC-8788.spec.ts
Outdated
Show resolved
Hide resolved
...ebapp/test/e2e_tests/specs/CriticalFlow/Cells/searchFilesInGroupConversation-TC-8788.spec.ts
Outdated
Show resolved
Hide resolved
apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversation.page.ts
Outdated
Show resolved
Hide resolved
...ebapp/test/e2e_tests/specs/CriticalFlow/Cells/searchFilesInGroupConversation-TC-8788.spec.ts
Outdated
Show resolved
Hide resolved
...ebapp/test/e2e_tests/specs/CriticalFlow/Cells/searchFilesInGroupConversation-TC-8788.spec.ts
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #20173 +/- ##
=======================================
Coverage 45.53% 45.53%
=======================================
Files 1632 1632
Lines 40337 40337
Branches 8334 8334
=======================================
Hits 18366 18366
Misses 20040 20040
Partials 1931 1931
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…rsation.page.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
...ebapp/test/e2e_tests/specs/CriticalFlow/Cells/searchFilesInGroupConversation-TC-8788.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
...ebapp/test/e2e_tests/specs/CriticalFlow/Cells/searchFilesInGroupConversation-TC-8788.spec.ts
Outdated
Show resolved
Hide resolved
...ebapp/test/e2e_tests/specs/CriticalFlow/Cells/searchFilesInGroupConversation-TC-8788.spec.ts
Outdated
Show resolved
Hide resolved
apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversation.page.ts
Outdated
Show resolved
Hide resolved
…rsation.page.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rsation.page.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
...ebapp/test/e2e_tests/specs/CriticalFlow/Cells/searchFilesInGroupConversation-TC-8788.spec.ts
Outdated
Show resolved
Hide resolved
apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversationFiles.page.ts
Show resolved
Hide resolved
…sInGroupConversation-TC-8788.spec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
...ebapp/test/e2e_tests/specs/CriticalFlow/Cells/searchFilesInGroupConversation-TC-8788.spec.ts
Outdated
Show resolved
Hide resolved
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/AccountSettingsSpecs/accountSettings.spec.ts (❌ 1 failed,
|
…sInGroupConversation-TC-8788.spec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversationFiles.page.ts
Show resolved
Hide resolved
...ebapp/test/e2e_tests/specs/CriticalFlow/Cells/searchFilesInGroupConversation-TC-8788.spec.ts
Outdated
Show resolved
Hide resolved
…sInGroupConversation-TC-8788.spec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
...ebapp/test/e2e_tests/specs/CriticalFlow/Cells/searchFilesInGroupConversation-TC-8788.spec.ts
Show resolved
Hide resolved
apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversationFiles.page.ts
Show resolved
Hide resolved
apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversation.page.ts
Outdated
Show resolved
Hide resolved
apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversation.page.ts
Outdated
Show resolved
Hide resolved
apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversationFiles.page.ts
Outdated
Show resolved
Hide resolved
...ebapp/test/e2e_tests/specs/CriticalFlow/Cells/searchFilesInGroupConversation-TC-8788.spec.ts
Outdated
Show resolved
Hide resolved
...ebapp/test/e2e_tests/specs/CriticalFlow/Cells/searchFilesInGroupConversation-TC-8788.spec.ts
Show resolved
Hide resolved
…sInGroupConversation-TC-8788.spec.ts Co-authored-by: Mark Brockhoff <95471369+markbrockhoff@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversationFiles.page.ts
Show resolved
Hide resolved
apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversationFiles.page.ts
Outdated
Show resolved
Hide resolved
|



Pull Request
Summary
Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)
Screenshots or demo (if the user interface changed)
Notes for reviewers