Simplify rusty-jwt-tools Nix setup #4952
Merged
+127
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like `buildRustPackage` improved. Thus, we can simplify this Nix derivation and - because rusty-jwt-tool now has a `Cargo.lock` file on toplevel - drop cargo lock file related logic.
zebot
added
the
ok-to-test
This can be overridden on higher level. But, here I see no reason to not allow it...
The `now` parameter of `generate_dpop_access_token` has been removed; See https://github.com/wireapp/rusty-jwt-tools/blob/b5de03a239d41b51e7cf9cd7c2674fa6be205134/CHANGELOG.md#L22
supersven
force-pushed
the
sventennie/simplify-rusty-nix
branch
from
9cd65da to
6c59918
Compare
supersven
force-pushed
the
sventennie/simplify-rusty-nix
branch
from
cb6653e to
ac1dfa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
buildRustPackageimproved. Thus, we can simplify this Nix derivation and - because rusty-jwt-tool now has aCargo.lockfile on toplevel - drop cargo lock file related logic.This also updates
rusty-jwt-tools. I've checked the FFI bindings: these should be fine.Because rusty-jwt-tool removed some Haskell FFI tests, I've ported them to our code base.
Ticket: https://wearezeta.atlassian.net/browse/WPB-22735
Checklist
changelog.d