-
Notifications
You must be signed in to change notification settings - Fork 45
fix(sync): set up account even with the app in the background [WPB-20795] #4490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sync): set up account even with the app in the background [WPB-20795] #4490
Conversation
b1c51c2 to
108fbfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀 ! Finally some DI module. Left a comment for the koverage since otherwise tests for this module won't run on the pipeline (like the case we had with :cells) 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add this new module to the config for crowdin.yml 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we could automate this somehow...
I am thinking of using Gradle to detect dependencies and automagically add these entries to crowdin.yml during project configuration or similar.
Making modules easy to create / friction-less is probably the most important step towards promoting modularity.
The dream would be having just:
plugins {
id(libs.plugins.wire.android.library.get().pluginId)
}[...] and the module is created. No need to do any more work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made it :P
Now we just need to create them modules. They are added automagically as we build. Hard to miss now.
ecf3414 to
85901d8
Compare
|



https://wearezeta.atlassian.net/browse/WPB-20795
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
If a user puts the app in the background whilst doing Slow Sync after logging in, Sync doesn't continue.
Causes
Android OS will say "Stop it, please - Or deal with the consequences".
Solutions
Take advantage of the new
:workmodule within Kalium, which exposes Initial Sync works.Work.InitialSynccomplete.Modularisation
I thought of going ahead and making this monitor + worker in a module.
This required some extra modularisation, like moving
Notification,DIandMediastuff to:core, so I did the lifting there too.Dependencies
Needs releases with:
Testing
Test Coverage
How to Test
Login in the app, or use the debug settings to "Force sync" :)
A
Setting up Wire...notification will appear if the WorkManager decides aForegroundServiceis needed (Android 11 or older).PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.