Default button polarity to active-LOW across all firmware types#25
Open
Default button polarity to active-LOW across all firmware types#25
Conversation
…gative claims number.
…rect-Release-of-RefCountedDigitalPin Fixed RefCountedDigitalPin.h and SSD1306Display for Heltec v4
…reply `gps sync` reply: fill buffer with text
Nearly all LoRa boards use a boot button that pulls to ground when pressed.
weebl2000
force-pushed
the
default-button-low
branch
from
529e28f to
762b0ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nearly all LoRa boards use a boot button that pulls to ground when pressed. The T1000-E is the one exception — it uses a capacitive touch button that is active-HIGH (confirmed by Meshtastic's
BUTTON_ACTIVE_LOW false).Changes:
USER_BTN_PRESSEDtoLOWwhere not already defined (ESP32Board.h, UITask.cpp, XiaoNrf52Board.h)LOWbutton checks withUSER_BTN_PRESSEDin UITask and board filesUSER_BTN_PRESSED=HIGHwithNRF_GPIO_PIN_SENSE_HIGH— changed to active-LOW withSENSE_LOWUSER_BTN_PRESSED=LOW(now the default)USER_BTN_PRESSED=HIGHandSENSE_HIGH(correct for this hardware), but fixbuttonStateChanged()to useUSER_BTN_PRESSEDinstead of hardcodedLOWI found out when I was working on meshcore-dev#1347 — it was actually releasing the boot button that would trigger the wakeup, not the pressing.
Build firmware: Build from this branch
Mirror of meshcore-dev#1612