-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: bump to express 5 #5564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: bump to express 5 #5564
Conversation
|
I still need to investigate why some content-types are not being changed, since JavaScript files are now "text/javascript", but somewhere that content-type is still not being updated, and also run the allowed-host tests. |
Can you provide where? It can be a problem in |
7f7aa4e to
6254bed
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5564 +/- ##
===========================================
- Coverage 83.47% 60.79% -22.68%
===========================================
Files 13 13
Lines 2051 2051
Branches 755 755
===========================================
- Hits 1712 1247 -465
- Misses 305 673 +368
- Partials 34 131 +97 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
6254bed to
07cc1f0
Compare
|
Okay, the content-type issue was coming from webpack-dev-middleware, updating it fixed everything. |
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Breaking Changes
Additional Info
While with Express there are hardly any changes other than adding support for some encodings or changing the regex path match, so nothing in the Express code will change for now. However, it is necessary to update
http-proxy-middleware, since in version 2 they have a resolution to use Express 4, whereas version 3 of that package already allows a different version of Express and other packages. :)