Skip to content

Conversation

@bjohansebas
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Breaking Changes

Additional Info

While with Express there are hardly any changes other than adding support for some encodings or changing the regex path match, so nothing in the Express code will change for now. However, it is necessary to update http-proxy-middleware, since in version 2 they have a resolution to use Express 4, whereas version 3 of that package already allows a different version of Express and other packages. :)

@bjohansebas
Copy link
Member Author

I still need to investigate why some content-types are not being changed, since JavaScript files are now "text/javascript", but somewhere that content-type is still not being updated, and also run the allowed-host tests.

@alexander-akait
Copy link
Member

I still need to investigate why some content-types are not being changed, since JavaScript files are now "text/javascript", but somewhere that content-type is still not being updated, and also run the allowed-host tests.

Can you provide where?

It can be a problem in webpack-dev-middleware

@codecov
Copy link

codecov bot commented Dec 27, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.79%. Comparing base (792b2f0) to head (9629630).

Files with missing lines Patch % Lines
lib/Server.js 0.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5564       +/-   ##
===========================================
- Coverage   83.47%   60.79%   -22.68%     
===========================================
  Files          13       13               
  Lines        2051     2051               
  Branches      755      755               
===========================================
- Hits         1712     1247      -465     
- Misses        305      673      +368     
- Partials       34      131       +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
@bjohansebas
Copy link
Member Author

Okay, the content-type issue was coming from webpack-dev-middleware, updating it fixed everything.

@bjohansebas bjohansebas marked this pull request as ready for review December 27, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants