Backport security fix from v5.2.1 to version-4 (non-Chromium browser dev-server vulnerability)#5534
Open
Wajih-Ul-Hasan wants to merge 2 commits intowebpack:version-4from
Open
Backport security fix from v5.2.1 to version-4 (non-Chromium browser dev-server vulnerability)#5534Wajih-Ul-Hasan wants to merge 2 commits intowebpack:version-4from
Wajih-Ul-Hasan wants to merge 2 commits intowebpack:version-4from
Conversation
Author
|
Hi @alexander-akait — tagging you as discussed in Issue #5313. This PR backports the dev-server security fix for non-Chromium browsers to the |
Member
|
Sorry, it is not a good fix, we can't apply security fix using |
Author
|
@alexander-akait If you have any better logic in your mind ,kindly share it with me. I will implement it. |
Member
|
There is a start of work - #5514, just need to backport this logic from v5 to v4 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backported the security patch from
v5.2.1to theversion-4branch to prevent dev client injection into unauthorized or potentially malicious browsers via the/webpack-dev-serverroute.What This Fixes
User-AgentdetectionContext
Relevant to: #5313
Inspired by: #5315 (official v5.2.1 patch)
Since
react-scripts@5.0.1depends onwebpack-dev-server@4.x, and upgrading to v5 is not always viable for projects in production, this patch brings essential security hardening to the v4 codebase.Implementation Details
isTrustedClient()helper to verify presence ofwebpack-dev-server-clientheader/webpack-dev-serverroute now denies access (403) if the required header is missingThanks for considering this backport 🙏
Happy to adjust based on any review feedback.