Skip to content

Comments

refactor: improve prop types and fix mobx#709

Merged
valscion merged 2 commits intomainfrom
improve-prop-types-and-mobx
Feb 20, 2026
Merged

refactor: improve prop types and fix mobx#709
valscion merged 2 commits intomainfrom
improve-prop-types-and-mobx

Conversation

@alexander-akait
Copy link
Member

Summary

Refactor:

  • adding prop types, maybe in future we will add jsdoc typescript
  • fix mobx, now we don't rerender some things multiple time

What kind of change does this PR introduce?

refactor

Did you add tests for your changes?

Existing

Does this PR introduce a breaking change?

No

If relevant, what needs to be documented once your changes are merged or what have you already documented?

Nothing

@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.35%. Comparing base (26b83f6) to head (cba59d2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #709   +/-   ##
=======================================
  Coverage   70.35%   70.35%           
=======================================
  Files          17       17           
  Lines         914      914           
  Branches      308      308           
=======================================
  Hits          643      643           
  Misses        238      238           
  Partials       33       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexander-akait
Copy link
Member Author

@valscion ready for review

Copy link
Member

@valscion valscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other changes make sense to me (although I didn't double-check all the proptypes but trust you set them up correctly) but the webpack config conditional change seemed strange to me

@alexander-akait
Copy link
Member Author

@valscion Ready for review again 👍

Copy link
Member

@valscion valscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@valscion valscion merged commit 77599a4 into main Feb 20, 2026
7 checks passed
@valscion valscion deleted the improve-prop-types-and-mobx branch February 20, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants