-
Notifications
You must be signed in to change notification settings - Fork 55
Restrict scale's values of dequantizeLinear and quantizeLinear to be positive and nonzero #906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fdwr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
fdwr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM after 2 comments.
huningxin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fdwr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
(awaiting Phillis and Reilly before merging?)
This is a Spec change PR for #879 where we're discussing about the lack of widespread support for the current negative scale of
dequantizeLinearandquantizeLinearacross all backend.@fdwr @reillyeon @huningxin PTAL, thanks!
Preview | Diff