Fix error when python 3.12 tests skips #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joannatk
commented
Jul 15, 2025
joannatk
commented
- Fixes error when python 3.12 tests skipped, see 3.12 starts to return an error when all tests in a test file are skipped python/cpython#113661 for more information
- Bump versions
ustinov
approved these changes
Jul 15, 2025
rrourke
approved these changes
Jul 15, 2025
keep94
reviewed
Jul 16, 2025
Contributor
keep94
left a comment
keep94
left a comment
There was a problem hiding this comment.
Hi Joanna. Thanks for the work. Just one minor comment.
ustinov
reviewed
Jul 16, 2025
Contributor
ustinov
left a comment
ustinov
left a comment
There was a problem hiding this comment.
No need to add a comment as a duplicate, just use the literal forms
Co-authored-by: Artem Ustinov <ustinov@users.noreply.github.com>
Contributor
Author
Thank you @ustinov ! All jobs pass with the literal form as well 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.