Skip to content

Conversation

@abelfodil
Copy link

No description provided.

Copy link
Member

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, any chance to add a new test to cover that behavior?

@abelfodil abelfodil force-pushed the master branch 3 times, most recently from 5efaf08 to dfc3a38 Compare January 21, 2021 16:14
@abelfodil
Copy link
Author

done

@j0k3r j0k3r requested a review from Kdecherf January 21, 2021 16:28
@deafmute1
Copy link

@Kdecherf any chance of getting this merged?

@Kdecherf
Copy link
Member

Kdecherf commented May 6, 2021

@deafmute1 I'll try to review this PR in the coming weeks

@DennisGaida
Copy link

Any update on this? This was a good PR and necessary to support docker secrets.

@P1nk-P0nk
Copy link

Is there a way to help review/merge this ?
I would really like to use secrets in my setup.

@adamantike
Copy link

@j0k3r @Kdecherf, gentle ping to get this reviewed. It would be great to have support for Docker secrets!

@mmathau
Copy link

mmathau commented Apr 24, 2025

Is there a chance that this will get merged at some point?

@abelfodil abelfodil requested a review from j0k3r April 24, 2025 22:54
@Kdecherf
Copy link
Member

@deafmute1 I'll try to review this PR in the coming weeks

"coming weeks" 😬

I'll dedicate some time next month to review this, sorry for taking this long

@Kdecherf Kdecherf self-assigned this Apr 25, 2025
[[ ! $? -eq 0 ]] && exit 1 # Exit if last command failed
new_var="$(echo $var_name=$file_content)"
export $(echo $new_var | xargs)
done
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing some quoting here and [[ is bash-specific. This is sh, so maybe replace this whole block with something like:

for n in $(LC_ALL=C awk 'BEGIN {for (n in ENVIRON) if (n ~ /^[0-9A-Z_]+__FILE$/) print n}'); do
	if ! eval "${n%__FILE}=\$(cat -- \"\$$n\") && export ${n%__FILE}"; then
		printf 'Failed to read $%s\n' "$n" >&2
		exit 1
	fi
done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants