-
Notifications
You must be signed in to change notification settings - Fork 170
Add Docker Secret support #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
j0k3r
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, any chance to add a new test to cover that behavior?
5efaf08 to
dfc3a38
Compare
|
done |
|
@Kdecherf any chance of getting this merged? |
|
@deafmute1 I'll try to review this PR in the coming weeks |
|
Any update on this? This was a good PR and necessary to support docker secrets. |
|
Is there a way to help review/merge this ? |
|
Is there a chance that this will get merged at some point? |
"coming weeks" 😬 I'll dedicate some time next month to review this, sorry for taking this long |
| [[ ! $? -eq 0 ]] && exit 1 # Exit if last command failed | ||
| new_var="$(echo $var_name=$file_content)" | ||
| export $(echo $new_var | xargs) | ||
| done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing some quoting here and [[ is bash-specific. This is sh, so maybe replace this whole block with something like:
for n in $(LC_ALL=C awk 'BEGIN {for (n in ENVIRON) if (n ~ /^[0-9A-Z_]+__FILE$/) print n}'); do
if ! eval "${n%__FILE}=\$(cat -- \"\$$n\") && export ${n%__FILE}"; then
printf 'Failed to read $%s\n' "$n" >&2
exit 1
fi
donec78c7d0 to
919bdbd
Compare
919bdbd to
710d3e5
Compare
No description provided.