feat[bench]: add more random access #6371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Merging this PR will improve performance by 10.18%
Performance Changes
Comparing 
Footnotes
|
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
# Conflicts: # benchmarks-website-v2/server.js # benchmarks-website-v2/src/config.js # encodings/runend/benches/run_end_compress.rs
joseph-isaacs
added
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Benchmarks: PolarSignals ProfilingSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Random AccessSummary
Detailed Results Table
|
Contributor
Benchmarks: CompressionSummary
Detailed Results Table
|
onursatici
reviewed
Feb 10, 2026
| // Poisson process: exponential inter-arrival times with rate chosen to yield | ||
| // ~POISSON_EXPECTED_COUNT indices across the dataset. | ||
| let rate = POISSON_EXPECTED_COUNT as f64 / row_count as f64; | ||
| // SAFETY: rate is always positive (POISSON_EXPECTED_COUNT > 0, row_count > 0). |
Contributor
There was a problem hiding this comment.
nit: why SAFETY there is nothing unsafe?
Contributor
Author
There was a problem hiding this comment.
an unbounded loop?
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
onursatici
approved these changes
Feb 10, 2026
| /// For other datasets, includes dataset and pattern: | ||
| /// `random-access/{dataset}/{pattern}/{format}-tokio-local-disk`. | ||
| fn measurement_name(dataset: &str, pattern: Option<AccessPattern>, format: Format) -> String { | ||
| let fmt = format.ext(); |
Contributor
There was a problem hiding this comment.
can conflict if we ever run vortex-compact with vortex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.