Skip to content

Upgrade Pco to 1.0.1 #6354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robert3005 merged 4 commits into from
Feb 11, 2026
Merged

Upgrade Pco to 1.0.1 #6354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de68d4a
upgrade pco to 1.0.1
mwlon Feb 8, 2026
25002b5
reduce pco default values per page to 2048
mwlon Feb 8, 2026
9e1ad05
reset values per pco page
mwlon Feb 11, 2026
a3c28fc
resolve conflicts
mwlon Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ opentelemetry_sdk = "0.31.0"
parking_lot = { version = "0.12.3", features = ["nightly"] }
parquet = "57.1"
paste = "1.0.15"
pco = "0.4.4"
pco = "1.0.1"
pin-project-lite = "0.2.15"
primitive-types = { version = "0.14.0" }
proc-macro2 = "1.0.95"
Expand Down
10 changes: 5 additions & 5 deletions encodings/pco/src/array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,10 +297,10 @@ impl PcoArray {
let mut chunk_infos = vec![]; // the Vortex metadata
let mut page_buffers = vec![];
for chunk_start in (0..n_values).step_by(values_per_chunk) {
let cc = match_number_enum!(
let chunk_end = cmp::min(n_values, chunk_start + values_per_chunk);
let mut cc = match_number_enum!(
number_type,
NumberType<T> => {
let chunk_end = cmp::min(n_values, chunk_start + values_per_chunk);
let values = values.to_buffer::<T>();
let chunk = &values.as_slice()[chunk_start..chunk_end];
fc
Expand All @@ -309,8 +309,8 @@ impl PcoArray {
}
);

let mut chunk_meta_buffer = ByteBufferMut::with_capacity(cc.chunk_meta_size_hint());
cc.write_chunk_meta(&mut chunk_meta_buffer)
let mut chunk_meta_buffer = ByteBufferMut::with_capacity(cc.meta_size_hint());
cc.write_meta(&mut chunk_meta_buffer)
.map_err(vortex_err_from_pco)?;
chunk_meta_buffers.push(chunk_meta_buffer.freeze());

Expand Down Expand Up @@ -424,7 +424,7 @@ impl PcoArray {
.page_decompressor(page, page_n_values)
.map_err(vortex_err_from_pco)
.vortex_expect("page_decompressor should succeed with valid page data");
pd.decompress(&mut decompressed_values[old_len..new_len])
pd.read(&mut decompressed_values[old_len..new_len])
.map_err(vortex_err_from_pco)
.vortex_expect("decompress should succeed with valid compressed data");
} else {
Expand Down
Loading