Draft
Conversation
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
This should fix the CI failures right now. More detailed discussion that I'll write incoming... Basically we shouldn't be eagerly decompressing validity when filtering it, but for now to make sure things aren't broken this will have to do. Edit: This should fix the break on spiral as well @delta003, as reported by @danking --------- Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Onur Satici <onursatici@gmail.com> Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
CodSpeed Performance ReportMerging this PR will degrade performance by 25.14%Comparing
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | WallTime | u64_values_u8_codes[10M] |
259.4 µs | 222.5 µs | +16.6% |
| ❌ | WallTime | 1M_10pct[100000] |
44.2 µs | 49.4 µs | -10.52% |
| ❌ | WallTime | 1M_90pct[1000000] |
30.2 µs | 34 µs | -11.17% |
| ❌ | WallTime | u16_FoR[10M] |
8.1 µs | 10.9 µs | -25.14% |
| ❌ | WallTime | 1M_50pct[500000] |
24 µs | 27.2 µs | -11.62% |
| ❌ | WallTime | 1M_10pct[100000] |
22.8 µs | 30 µs | -24.05% |
Footnotes
-
1323 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
force-pushed
the
aduffy/filter-decimals
branch
2 times, most recently
from
afcc118 to
4f4fccd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See
cargo test -p vortex-file tests::gpu_scan