Call setMinZoom, setMaxZoom, setMinPitch and setMaxPitch in the right order to avoid error in Maplibre#2573
Open
Auspicus wants to merge 5 commits intovisgl:masterfrom
Open
Call setMinZoom, setMaxZoom, setMinPitch and setMaxPitch in the right order to avoid error in Maplibre#2573Auspicus wants to merge 5 commits intovisgl:masterfrom
Auspicus wants to merge 5 commits intovisgl:masterfrom
Conversation
Auspicus
commented
Dec 24, 2025
Auspicus
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a test to cover different cases where
minZoomandmaxZoomare adjusted together. Ensures thatminZoomandmaxZoomnever cross. The same has been done forminPitchandmaxPitch.fixes: #2572
see also: maplibre/maplibre-gl-js#6926 where a bug was fixed causing pitch to also throw an error if changed in the wrong order