[cli] Print notice on CLI startup when detecting an outdated version #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 59dfabb The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (237 failed)astro (25 failed):
example (25 failed):
express (26 failed):
fastify (26 failed):
hono (26 failed):
nextjs-turbopack (8 failed):
nextjs-webpack (26 failed):
nitro (25 failed):
nuxt (25 failed):
vite (25 failed):
📦 Local Production (181 failed)astro-stable (25 failed):
express-stable (26 failed):
fastify-stable (26 failed):
hono-stable (26 failed):
nitro-stable (26 failed):
nuxt-stable (26 failed):
vite-stable (26 failed):
🐘 Local Postgres (181 failed)astro-stable (25 failed):
express-stable (26 failed):
fastify-stable (26 failed):
hono-stable (26 failed):
nitro-stable (26 failed):
nuxt-stable (26 failed):
vite-stable (26 failed):
🌍 Community Worlds (11 failed)mongodb (1 failed):
redis (1 failed):
starter (8 failed):
turso (1 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
❌ 📦 Local Production
❌ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
❌ Some E2E test jobs failed:
Check the workflow run for details. |
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…me using `createRequire` with a relative path. When bundled by Vite/SvelteKit for SSR, the relative path becomes invalid because the output file is at a different location than the source file, causing a MODULE_NOT_FOUND error. The fix uses `import.meta.resolve()` which provides correct path resolution even in bundled environments. This commit fixes the issue reported at packages/world-local/src/init.ts:1-18 ## SvelteKit build fails: Cannot find module '../package.json' in bundled SSR code **What fails:** During SvelteKit SSR build, the `vite build` command fails with error: `Error: Cannot find module '../package.json'` in compiled code at `.svelte-kit/output/server/chunks/step-handler.js:1711:21` **How to reproduce:** ```bash cd workbench/sveltekit pnpm run build ``` During the "rendering chunks" phase, when Vite bundles the SSR output, the compiled code attempts to require `../package.json` which fails because the relative path from the bundled output file location is invalid. **Result:** ``` Error: Cannot find module '../package.json' Require stack: - /vercel/path0/workbench/sveltekit/.svelte-kit/output/server/chunks/step-handler.js ``` **Root cause:** The `packages/world-local/src/init.ts` file uses `createRequire(import.meta.url)` with a relative path `../package.json` to load the package.json file. When Rollup/Vite bundles this code for SSR, the relative path becomes invalid because the output file is at a different location than the source file. **Solution:** Use `import.meta.resolve()` which provides proper module path resolution even in bundled environments. Falls back to `createRequire()` for compatibility with test environments where `import.meta.resolve()` may not be available. Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This superseeds #657, which tried to use an npm plugin for this job, but was ugly and didn't work with pre-release versions, so I had claude implement it instead.
Essentially:
@workflow/cliglobally separately fromworkflow, sincep i workflow@latestwouldn't resolve the update warning, but this seems like a minor concern.