Open
Conversation
Contributor
|
clippy is sad |
Franklin-Qi
force-pushed
the
remove-libc-in-pgrep
branch
from
f06e910 to
36feec4
Compare
Contributor
Author
Thanks, it compiles successfully on Ubuntu. It seems to be a multi-system compatibility issue. I'm currently modifying the check error. |
Collaborator
|
failed tests has nothing to do with you; you can just blame about the complexity of SYSTEM DEVELOPMEN. XD these tests have now been successfully completed. |
Krysztal112233
requested changes
Feb 9, 2026
Franklin-Qi
force-pushed
the
remove-libc-in-pgrep
branch
2 times, most recently
from
b34da15 to
53516e6
Compare
Use rustix instead of libc and unsafe functions such as getpgrp, getsid, flock, gettid, getppid, getpgid, and getsid.
Franklin-Qi
force-pushed
the
remove-libc-in-pgrep
branch
from
53516e6 to
b5d03a8
Compare
Bluemangoo
reviewed
Feb 12, 2026
| @@ -445,17 +429,32 @@ pub fn grp2gid(_name: &str) -> io::Result<u32> { | |||
| /// # Safety | |||
Collaborator
There was a problem hiding this comment.
Since this function is no longer unsafe, the Safety comment is useless now.
| } | ||
| } | ||
|
|
||
| /// # Safety |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use rustix instead of libc and unsafe functions such as getpgrp, getsid, flock, gettid, getppid, getpgid, and getsid.
Closes: #595