Conversation
sylvestre
force-pushed
the
fix-leap-1
branch
3 times, most recently
from
023a112 to
8a09e66
Compare
sylvestre
force-pushed
the
fix-leap-1
branch
2 times, most recently
from
0d03461 to
2a25d41
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
==========================================
+ Coverage 97.79% 98.72% +0.93%
==========================================
Files 18 18
Lines 2445 2587 +142
Branches 68 69 +1
==========================================
+ Hits 2391 2554 +163
+ Misses 53 32 -21
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
NOTE: This commit only adds tests as the implementation was already working correctly. These tests document and verify the expected behavior for the embedded timezone edge case referenced in Debian bug #851934.
Add tests to verify that adding 0 years or 0 months returns the original date unchanged, including edge cases with Feb 29.
sylvestre
force-pushed
the
fix-leap-1
branch
from
2a25d41 to
bdbb439
Compare
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding years to Feb 29, if the target year is not a leap year, overflow to March 1 (GNU behavior). Previously clamped to Feb 28.