feat rocks: rework RocksDB bindings#1063
Draft
beryll1um wants to merge 1 commit intouserver-framework:developfrom
Draft
feat rocks: rework RocksDB bindings#1063beryll1um wants to merge 1 commit intouserver-framework:developfrom
beryll1um wants to merge 1 commit intouserver-framework:developfrom
Conversation
Contributor
Author
|
TODO:
... |
9ed0736 to
1e94e27
Compare
Contributor
Author
|
I've started implementing a more or less viable iterator instead of directly binding RocksDB methods. It's still rough, and some parts (like the bool type cast) are just for testing, but the basic outlines are already in place. I think it's better to make this pull a draft for now. |
1e94e27 to
f58b942
Compare
Contributor
Author
|
It looks like the Iterator is ready and needs to be reviewed. Unfortunately, implementing copying and postfix incrementing is impossible, as this would require copying, which is a rather complex operation in RocksDB (at least I didn't found a viable solution). |
f3d9d33 to
cfce6f7
Compare
916cbbf to
8f4b5f7
Compare
- Use std::optional for Get methods instead of empty strings when NotFound - Add RAII wrappers for RocksDB snapshots, iterators and write batches (rocks::Snapshot, rocks::Iterator, rocks::WriteBatch) - Ensure graceful DB shutdown: sync WAL and wait for compaction/close on the dedicated Rocks task processor - Link RocksDB privately from the rocks module (LINK_LIBRARIES_PRIVATE) BREAKING CHANGES: - storages::rocks::Client and storages::rocks::Component are removed - Component is now components::Rocks with GetDb() - Exception and RequestFailedException are removed in favor of StatusNokException - Config keys changed: db-path/task-processor -> db_path/max_background_jobs
8f4b5f7 to
5dbb13b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(rocks::Snapshot, rocks::Iterator, rocks::WriteBatch)
dedicated Rocks task processor
BREAKING CHANGES: