Skip to content

Fix typo in verified tick size definition#146

Open
gaetanmaisse wants to merge 2 commits intountitleduico:mainfrom
gaetanmaisse:patch-1
Open

Fix typo in verified tick size definition#146
gaetanmaisse wants to merge 2 commits intountitleduico:mainfrom
gaetanmaisse:patch-1

Conversation

@gaetanmaisse
Copy link
Contributor

@gaetanmaisse gaetanmaisse commented Feb 6, 2026

Description

Avatar > VerifiedTick

The tick class for the xs size is missing the closing bracket, which will cause the class to be invalid and the tick icon won't be sized correctly. That said, it looks like the tick attribute isn't used anywhere so I would advocate for removing it completely, WDYT?

Related issues

No related issue

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Style/UI change (visual improvements, no functional changes)
  • Accessibility improvement
  • Refactoring (code changes that neither fix a bug nor add a feature)
  • Performance improvement
  • Chore (dependency updates, tooling changes, etc.)

Testing

The VerifiedTick is still properly displayed in different sizes.

Testing checklist

NA

Manual testing steps

NA

Screenshots/Videos

NA

Before

NA

After

NA

Code quality checklist

  • Code style: Follows project conventions
  • ESLint: No linting errors
  • Prettier: Code is properly formatted
  • TypeScript: Full type coverage
  • Imports: Uses correct import paths (@/components/...)
  • Performance: No unnecessary re-renders or heavy computations
  • Error handling: Appropriate error boundaries and validation

📚 Documentation

NA

Breaking changes

NA

Migration guide

NA

Additional context

@gaetanmaisse gaetanmaisse marked this pull request as ready for review February 6, 2026 13:32
@deebov
Copy link
Contributor

deebov commented Feb 6, 2026

Hey @gaetanmaisse, thanks for the PR. Great catch!

it looks like the tick attribute

Do you mean data-verified? I just did a search in the global repo and it seems true, it isn't used anywhere. Feel free to remove it and request a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants