ICU-23292 add toString method to ICUResourceBundle
#3797
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sffc
reviewed
Dec 12, 2025
Comment on lines
334
to
339
| private enum RootType { | ||
| @Override | ||
| public String toString() { | ||
| return "UResourceBundle{" + "name=" + getBaseBundleName() + ",locale=" + getLocale() + '}'; | ||
| } | ||
|
|
||
| private enum RootType { |
Member
There was a problem hiding this comment.
Please fix the text indentation.
Also, this change is small/minor enough that it probably makes more sense to keep in your main PR.
Author
There was a problem hiding this comment.
Please fix the text indentation.
Oops, fixed.
Also, this change is small/minor enough that it probably makes more sense to keep in your main PR.
The thing is it's unrelated to my main PR - this issue is triggered by another debug flag.
sffc
previously approved these changes
Dec 17, 2025
markusicu
reviewed
Dec 18, 2025
|
|
||
| @Override | ||
| public String toString() { | ||
| return "UResourceBundle{" + "name=" + getBaseBundleName() + ",locale=" + getLocale() + '}'; |
Member
There was a problem hiding this comment.
Suggested change
| return "UResourceBundle{" + "name=" + getBaseBundleName() + ",locale=" + getLocale() + '}'; | |
| return "UResourceBundle{name=" + getBaseBundleName() + ", locale=" + getLocale() + '}'; |
mihnita
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ICU-23292. Issue found while testing #3795.