Backport small changes from Undo AI Gen 2#106
Merged
Conversation
`func.type.target` returns a `gdb.Type` object, not a type code integer.
When searching for the `return` statement, if we hit the function start breakpoint again it means the function body is a single line; break out of the loop instead of asserting.
If switching to the sending process fails, restore the debugger to its original position so the failed tool call does not leave the session in an unexpected state.
Previously, `reverse_finish` only restored the selected frame on failure. Just reverting the frame should work considering what `reverse_finish`, but restoring the full bookmarked time is safer, consistent with other tools and restores the frame anyway.
mark-undoio
approved these changes
Feb 25, 2026
Contributor
mark-undoio
left a comment
mark-undoio
left a comment
There was a problem hiding this comment.
All looks good - thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed some problems in our internal repository, which I think are worth backporting.