[RTM] Refactored ScrollableViewHelper to interface#635
Closed
renaudcerrato wants to merge 1 commit intoumano:masterfrom
renaudcerrato:move_scrollable_view_helper_to_interface
Closed
[RTM] Refactored ScrollableViewHelper to interface#635renaudcerrato wants to merge 1 commit intoumano:masterfrom renaudcerrato:move_scrollable_view_helper_to_interface
renaudcerrato wants to merge 1 commit intoumano:masterfrom
renaudcerrato:move_scrollable_view_helper_to_interface
Conversation
Author
|
I'm closing because of a more elegant solution (#636) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScrollableViewHelpershould be an interface for a cleaner API. Moreover, sinceSlidingUpPanelLayoutis only interested to know if the scrollable view can scroll, the return value should be a boolean.