Skip to content

feat: Implement TagClient.GetAsync in NGitLab.Client.Mock#1047

Merged
Toa741 merged 3 commits intomainfrom
tests-implement-tagclient-getasync-with-a-query
Feb 3, 2026
Merged

feat: Implement TagClient.GetAsync in NGitLab.Client.Mock#1047
Toa741 merged 3 commits intomainfrom
tests-implement-tagclient-getasync-with-a-query

Conversation

@mlemieuxlafontaine-ubi
Copy link
Contributor

Well to be exact, the method was already implemented, but we could not pass in a query without the method crashing. Implemented the behavior as closely as possible to the GitLab's api sorting and filtering

@mlemieuxlafontaine-ubi mlemieuxlafontaine-ubi marked this pull request as ready for review February 3, 2026 20:11
@mlemieuxlafontaine-ubi mlemieuxlafontaine-ubi requested a review from a team as a code owner February 3, 2026 20:11
@mlemieuxlafontaine-ubi mlemieuxlafontaine-ubi requested review from Toa741 and removed request for a team February 3, 2026 20:11
@mlemieuxlafontaine-ubi mlemieuxlafontaine-ubi force-pushed the tests-implement-tagclient-getasync-with-a-query branch from 8c5000d to 953f428 Compare February 3, 2026 20:55
@Toa741 Toa741 merged commit fd7c029 into main Feb 3, 2026
7 checks passed
@Toa741 Toa741 deleted the tests-implement-tagclient-getasync-with-a-query branch February 3, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants