Handle pass-through assertion methods that are just forwarding parameters #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leifwalsh
force-pushed
the
bug/deprecated-assertion-methods
branch
2 times, most recently
from
229aa52 to
0784a81
Compare
…ters This deals with the "deprecated assertion names" like assertEquals forwarding to assertEqual, and possibly others like them. Closes #85
thejunglejane
requested changes
Jul 7, 2018
Contributor
thejunglejane
left a comment
thejunglejane
left a comment
There was a problem hiding this comment.
In conjunction with #78, I think we have enough evidence now that we should rethink how we capture the note and the msg arguments. Let’s think through a different approach that handles both (and other permutations of the msg argument we can find/think of), and I can add tests for #78 like you did here for #85 to help get us started.
thejunglejane
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deals with the "deprecated assertion names" like assertEquals forwarding to assertEqual, and possibly
others like them.
Closes #85