Fix a Y2038 bug by replacing Int32x32To64 with regular multiplication#1901
Open
CookiePLMonster wants to merge 1 commit intotursodatabase:mainfrom
Open
Fix a Y2038 bug by replacing Int32x32To64 with regular multiplication#1901CookiePLMonster wants to merge 1 commit intotursodatabase:mainfrom
Int32x32To64 with regular multiplication#1901CookiePLMonster wants to merge 1 commit intotursodatabase:mainfrom
Conversation
Author
|
"Upstream" SQLite fixed this bug in sqlite/sqlite@8d6e3f5. They are missing a |
CookiePLMonster
force-pushed
the
y2038-patch
branch
from
d7e84c6 to
ee64d08
Compare
CookiePLMonster
force-pushed
the
y2038-patch
branch
from
ee64d08 to
34c21cb
Compare
|
Please merge Turso Silent Patch, the most legendary collab since PB & J! :-) |
Int32x32To64 macro internally truncates the arguments to int32, while time_t is 64-bit on most/all modern platforms. Therefore, usage of this macro creates a Year 2038 bug.
CookiePLMonster
force-pushed
the
y2038-patch
branch
from
34c21cb to
dd69228
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue has also been reported in "upstream" SQLite, currently awaiting approval: https://sqlite.org/forum/forumpost/51e004d479
Int32x32To64macro internally truncates the arguments to int32, whiletime_tis 64-bit on most/all modern platforms. Therefore, usage of this macro creates a Year 2038 bug.I detailed this issue a while ago in a writeup, and spotted the same issue in this repository when updating the list of affected repositories:
https://cookieplmonster.github.io/2022/02/17/year-2038-problem/