Precompute compressed lenghts of the training data#2
Open
rdno wants to merge 1 commit intotsoding:mainfrom
Open
Precompute compressed lenghts of the training data#2rdno wants to merge 1 commit intotsoding:mainfrom
rdno wants to merge 1 commit intotsoding:mainfrom
Conversation
By precomputing and storing the compressed lengths one deflate call can be avoided in `ncd` function.
|
What about precomputing the compressed lengths of the test data while keeping the original text around (same for the training data) as well? (Possibly pouring some threads for that.) So, the only final computation will happen in the combined. I'm not too familiar with C, but I used a similar albeit naive approach in Kotlin, which is pathetically slow. [edit] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I came across this implementation. I had an idea to speed up the computations. I don't expect you to merge it.
By pre-computing and storing the compressed lengths of the training data, one deflate call can be avoided in
ncdfunction. I've observed ~33% performance increase.Great project.
Thanks.