[dev] [carhartlewis] lewis/comp-form-type-finding-fix#2159
[dev] [carhartlewis] lewis/comp-form-type-finding-fix#2159github-actions[bot] wants to merge 4 commits intomainfrom
Conversation
PR SummaryLow Risk Overview This adds an explicit Written by Cursor Bugbot for commit c2f2e59. This will update automatically on new commits. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
| function toDbEvidenceFormType(formType: EvidenceFormType): DbEvidenceFormType { | ||
| return EXTERNAL_TO_DB_FORM_TYPE[formType]; | ||
| } |
There was a problem hiding this comment.
Duplicated form-type mapping exists in API app
Low Severity
The EXTERNAL_TO_DB_FORM_TYPE mapping and toDbEvidenceFormType function are exact duplicates of EXTERNAL_TO_DB and toDbEvidenceFormType already defined in apps/api/src/evidence-forms/evidence-form-type-map.ts. If a new EvidenceFormType variant is added, both copies must be updated independently, creating a maintenance risk. Ideally this mapping would live in a shared location (e.g., @comp/company) or a shared internal package to avoid drift.


This is an automated pull request to merge lewis/comp-form-type-finding-fix into dev.
It was created by the [Auto Pull Request] action.