Delay secret unmount #112
Open
Delay secret unmount #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakob-Naucke
force-pushed
the
quiet-deletion
branch
from
870c35b to
795571a
Compare
Jakob-Naucke
force-pushed
the
quiet-deletion
branch
2 times, most recently
from
fd28bdd to
13bb232
Compare
instead of templates, to use in a test and save some lines Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Previously, disk encryption secrets were deleted directly with the associated machine resource, and subsequently unmounted from Trustee pods, which causes a pod restart. Because secret deletion is merely housekeeping, not a time-critical purge, delay unmount until the next secret mount: Whenever secrets are to be mounted, partition secrets into "mount" and "discard". Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Jakob-Naucke
force-pushed
the
quiet-deletion
branch
from
13bb232 to
c7a706e
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Jakob-Naucke The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Jakob-Naucke: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, disk encryption secrets were deleted directly with the
associated machine resource, and subsequently unmounted from Trustee
pods, which causes a pod restart. Because secret deletion is merely
housekeeping, not a time-critical purge, delay unmount until the next
secret mount: Whenever secrets are to be mounted, partition secrets
into "mount" and "discard".
Picks one tests-related commit out of #111.