Skip to content

Fix Replay Data Corruption for Non-JSON Payloads (#2813) #2959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bharathkumar39293 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Replay Data Corruption for Non-JSON Payloads (#2813) #2959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions apps/webapp/app/components/runs/v3/ReplayRunDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,7 @@ function ReplayContent({ runFriendlyId, failedRedirect }: ReplayRunDialogProps)
}

queueFetcher.load(
`/resources/orgs/${params.organizationSlug}/projects/${
params.projectParam
`/resources/orgs/${params.organizationSlug}/projects/${params.projectParam
}/env/${envSlug}/queues?${searchParams.toString()}`
);
}
Expand Down Expand Up @@ -163,9 +162,9 @@ function ReplayForm({

const isSubmitting = navigation.formAction === formAction;

const editablePayload =
replayData.payloadType === "application/json" ||
replayData.payloadType === "application/super+json";
const isLargePayload = replayData.payloadType === "application/store";
const isTooLargeToEdit = (replayData.payload?.length ?? 0) > 512 * 1024;
const editablePayload = !isLargePayload && !isTooLargeToEdit;

const [tab, setTab] = useState<"payload" | "metadata">(editablePayload ? "payload" : "metadata");

Expand Down Expand Up @@ -275,10 +274,16 @@ function ReplayForm({
<InfoIconTooltip
content={
<span className="text-sm">
Payload is not editable for runs with{" "}
<TextLink to={docsPath("triggering#large-payloads")}>
large payloads.
</TextLink>
{isLargePayload ? (
<>
Payload is not editable for runs with{" "}
<TextLink to={docsPath("triggering#large-payloads")}>
large payloads.
</TextLink>
</>
) : (
"Payload is too large to edit."
)}
</span>
}
/>
Expand Down
20 changes: 1 addition & 19 deletions apps/webapp/app/v3/replayTask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,7 @@ import { RunOptionsData } from "./testTask";
export const ReplayRunData = z
.object({
environment: z.string().optional(),
payload: z
.string()
.optional()
.transform((val, ctx) => {
if (!val) {
return "{}";
}

try {
JSON.parse(val);
return val;
} catch {
ctx.addIssue({
code: z.ZodIssueCode.custom,
message: "Payload must be a valid JSON string",
});
return z.NEVER;
}
}),
payload: z.string().optional(),
metadata: z
.string()
.optional()
Expand Down