-
-
Notifications
You must be signed in to change notification settings - Fork 940
chore(webapp): Concurrency page UI improvements #2825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samejr
wants to merge
7
commits into
main
Choose a base branch
from
concurrency-page-ui-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a88d60c
Prevents buttons spanning 100% width by default
samejr 8fe4492
Adds new variant to Table.tsx to hide row hover states
samejr 13d737f
Truncate long branch names and show tooltip
samejr 552fde2
Prevents the default “type=submit” on tooltips to stop them triggerin…
samejr b8acfd5
Show a clear message when you have unallocated concurrency
samejr 62dd5a8
Uses Simplr to pluralize “bundle[s]” in the modal
samejr 0730342
Updates the concurrency limit docs page
samejr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 MEDIUM - Intentional tabIndex=-1 on tooltip trigger
Agent: react
Category: quality
Description:
SimpleTooltip uses tabIndex={-1} on type='button' element. This is likely intentional to prevent tooltip triggers from being focusable while still being mouse-interactive, but should be documented.
Suggestion:
Add a comment explaining why tabIndex={-1} is used intentionally, or consider if keyboard accessibility should be supported.
Confidence: 60%
Rule:
ts_use_appropriate_tabindex_valuesReview ID:
fb475f6c-79ba-4905-bbc9-50e570158b3aRate it 👍 or 👎 to improve future reviews | Powered by diffray