chore(CI): specify --tag when npm publishing
#414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uni-kakurenbo
force-pushed
the
chore/spec-tags-when-releasing
branch
from
0e1c933 to
00cf401
Compare
Pugma
requested changes
Sep 28, 2025
Contributor
Pugma
left a comment
Pugma
left a comment
There was a problem hiding this comment.
作業ありがとうございます！
一点だけ、確認をお願いします…！
| git config user.name "GitHub Actions" | ||
| git config user.email "actions@github.com" | ||
| npm version $NEW_VERSION -m "CI: update to $NEW_VERSION [ci skip]" |
Contributor
There was a problem hiding this comment.
ここでダブルクォート足したのって何らかの意図ありますか…？
コミットメッセージの範囲を示すダブルクォートと衝突しそうな気がします 👀
Contributor
Author
There was a problem hiding this comment.
いつも shell-check に怒られるので手癖で足してしまいました
(コミットメッセージの部分は気づいてこっそり force-push したんですが間に合いませんでした．今は直ってると思います、すみません)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.