fix app crash because google is undefined in a PWA if the user is offline and cache is disabled.#956
Open
xMokAx wants to merge 1 commit intotomchentw:masterfrom
Open
fix app crash because google is undefined in a PWA if the user is offline and cache is disabled.#956xMokAx wants to merge 1 commit intotomchentw:masterfrom
xMokAx wants to merge 1 commit intotomchentw:masterfrom
Conversation
…line and cache is disabled.
|
Hello @xMokAx this repo is unmaintained, and pull requests does not merged since more than a year. Please consider to use a successor library |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When i open my app in offline mode if https://maps.googleapis.com/maps/api/js is not available in browser cache like disk cache the app craches because google is not defined.
You can see the error here https://xmokax.github.io/map-app/ by following these steps:
This PR to fixes this problem.