Conversation
Contributor
|
Hi @hust-nj ! Thanks for bringing this to our attention! I will review your PR asap. |
Contributor
|
Hi @hust-nj , I had a look at your PR. Here's some feedback:
// A comment
int main() {
return 0;
/* comment */
}yields int main() {
return 0;
/* comment */
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think there are 2 main problems in current
clean_copyright_commentsfunctionRedPajama-Data/data_prep/github/github_clean_dedup_local.py
Line 27 in 567ac9a
First, It cannot remove the copyright successfully in the following C-style code because of the early return in
RedPajama-Data/data_prep/github/github_clean_dedup_local.py
Line 37 in 567ac9a
Second, I find that, when the file is large, the regex sometimes costs much time in my experiment, I think we only need to find the copyright in the first 100 lines.