Use locals as this value inside filter functions#185
Open
wankdanker wants to merge 1 commit intotj:masterfrom
Open
Use locals as this value inside filter functions#185wankdanker wants to merge 1 commit intotj:masterfrom
this value inside filter functions#185wankdanker wants to merge 1 commit intotj:masterfrom
Conversation
This little patch changes the value of `this` inside all filter functions to that of the `locals` object. Currently it seems that `this` is a reference to the `filters` object. The purpose is to expose additional data to the filter function without having to pass additional arguments from the template. This could potentially be a breaking change if users are currently relying on `this` being a reference to the `filters` object from within their custom filters. Additional changes could be relatively easily made to make this configurable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This little patch changes the value of
thisinside all filter functions tothat of the
localsobject. Currently it seems thatthisis a reference tothe
filtersobject. The purpose is to expose additional data to the filterfunction without having to pass additional arguments from the template.
This could potentially be a breaking change if users are currently relying on
thisbeing a reference to thefiltersobject from within their customfilters. Additional changes could be relatively easily made to make this
configurable.