Remove all references to coverage pools #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes all references to coverage pools including adding it's tvl to the total tvl value. Thanks to this we can remove `@keep-network/coverage-pools` and `@threshold-network/coverage-pools` libs. Note: `useFetchTvl.test.jsx` test is not working after our tbtc-v2.ts 2.3 integration. All non-working tests should be improved in a separate Pull Request.
michalinacienciala
approved these changes
Dec 28, 2023
Contributor
michalinacienciala
left a comment
michalinacienciala
left a comment
There was a problem hiding this comment.
Looks good from the CI point of view. There's one more thing we'll need to do outside of token-dashboard repository that's a consequence of this change - remove the coverage-pools from the CI flow config (basically revert keep-network/ci#35). I'll do that. We don't need to wait with merging current PR for that change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #668
Removes all references to coverage pools including adding it's tvl to the total tvl value. Thanks to this we can remove
@keep-network/coverage-poolsand@threshold-network/coverage-poolslibs.Note:
useFetchTvl.test.jsxtest is not working after our tbtc-v2.ts 2.3 integration. All non-working tests should be improved in a separate Pull Request.